return type=unknown instead of error=no_content

8 years ago · 097e999768
--- a/controllers/Parse.php
+++ b/controllers/Parse.php
@ -125,9 +125,10 @@ class Parse {
    // TODO: look for other content like OEmbed or other known services later


    return $this->respond($response, 400, [
      'error' => 'no_content',
      'error_description' => 'No usable content could be found at the given URL'
    return $this->respond($response, 200, [
      'data' => [
        'type' => 'unknown',
      ]
    ]);
  }

--- a/tests/ParseTest.php
+++ b/tests/ParseTest.php
@ -118,4 +118,14 @@ class ParseTest extends PHPUnit_Framework_TestCase {
    $this->assertObjectNotHasAttribute('content', $data->data);
  }

  public function testNoHEntryMarkup() {
    $url = 'http://source.example.com/no-h-entry';
    $response = $this->parse(['url' => $url]);

    $body = $response->getContent();
    $this->assertEquals(200, $response->getStatusCode());
    $data = json_decode($body);
    $this->assertEquals('unknown', $data->data->type);
  }

 }
--- a/tests/data/source.example.com/no-h-entry
+++ b/tests/data/source.example.com/no-h-entry
@ -0,0 +1,14 @@
 HTTP/1.1 200 OK
 Server: Apache
 Date: Wed, 09 Dec 2015 03:29:14 GMT
 Content-Type: text/html; charset=utf-8
 Connection: keep-alive

 <html>
  <head>
    <title>Test</title>
  </head>
  <body>
    <p>This page has a link to <a href="http://target.example.com">target.example.com</a> and some <b>formatted text</b> but has no h-entry markup.</p>
  </body>
 </html>