From bc2a7e953f24c0322f5a395df5be6d070cab0b95 Mon Sep 17 00:00:00 2001 From: Aaron Parecki Date: Mon, 1 Jun 2015 16:14:50 +0000 Subject: [PATCH 1/2] fix check for whether to send namespaced params in subscription verification --- lib/PushTask.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/PushTask.php b/lib/PushTask.php index c736503..c4a6eae 100644 --- a/lib/PushTask.php +++ b/lib/PushTask.php @@ -14,7 +14,7 @@ class PushTask { $exp_ts = time() + $lease_seconds; $exp_date = date('Y-m-d H:i:s', $exp_ts); - if($feed->namespaced) { + if($subscription->namespaced) { $prefix = 'hub.'; } else { $prefix = ''; @@ -29,6 +29,8 @@ class PushTask { $push_params[$prefix.'lease_seconds'] = $lease_seconds; } + echo "Verifying subscription to ".$feed->feed_url." for callback ".$subscription->callback_url."\n"; + $url = parse_url($subscription->callback_url); if($q=k($url, 'query')) { parse_str($q, $existing_params); @@ -37,6 +39,7 @@ class PushTask { $url['query'] = http_build_query($push_params); $url = build_url($url); + echo "\t".$url."\n"; $response = request\get_url($url, true); $subscription->challenge_response = $response['headers']."\n\n".$response['body']; From 0d09ce1203b86c00350bcac65e316f6ee60204ed Mon Sep 17 00:00:00 2001 From: Aaron Parecki Date: Tue, 16 Jun 2015 07:52:46 -0700 Subject: [PATCH 2/2] update default lease expiration set to one week plus an extra hour --- lib/PushTask.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PushTask.php b/lib/PushTask.php index c4a6eae..4b7237f 100644 --- a/lib/PushTask.php +++ b/lib/PushTask.php @@ -10,7 +10,7 @@ class PushTask { $feed = db\get_by_id('feeds', $subscription->feed_id); // Choose the expiration for the subscription - $lease_seconds = 86400*3; + $lease_seconds = 86400*7 + 3600; $exp_ts = time() + $lease_seconds; $exp_date = date('Y-m-d H:i:s', $exp_ts);